https://bugs.kde.org/show_bug.cgi?id=406105

Pedro <pe...@outlook.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/gwenview/-/commit/de21
                   |                            |528bff79cd8173b92eee040269f
                   |                            |d480f487e

--- Comment #6 from Pedro <pe...@outlook.com> ---
Git commit de21528bff79cd8173b92eee040269fd480f487e by Pedro Hernandez.
Committed on 06/12/2024 at 05:01.
Pushed by felixernst into branch 'master'.

Fix incorrect numbering in full screen mode for the first image

The function `FullScreenContent::updateDocumentCountLabel()` is responsible
for updating the UI element that shows numbering in full screen mode.
However, it is only called once when Gwenview is launched to display an
image (e.g., from a file explorer or terminal). At that point, the function
pulls data from the model (an instance of `SortedDirModel`), but the model
isn't fully loaded, and it also requires an index to be selected before
providing accurate data. The correct timing for when the model can return
valid data happens in the slot `ContextManager::selectUrlToSelect()`,
specifically, when the selected index is not the root.

As a result, the data displayed is incorrect, showing `0 of 0` which are
default values.

This modification resolves the issue by connecting the signal
`ContextManager::selectionChanged()` to the
`FullScreenContent::updateDocumentCountLabel()` slot, which is emitted
when the model selection changes. To enable this, the slot needs to be
made public so it can be accessed from another class.

M  +1    -1    app/fullscreencontent.h
M  +1    -0    app/mainwindow.cpp

https://invent.kde.org/graphics/gwenview/-/commit/de21528bff79cd8173b92eee040269fd480f487e

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to