https://bugs.kde.org/show_bug.cgi?id=346188

Alex Merry <alex.me...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED
      Latest Commit|http://commits.kde.org/extr |http://commits.kde.org/extr
                   |a-cmake-modules/6745bd7e479 |a-cmake-modules/fb4d91996af
                   |6560959bb67e33b7c7f86f96a5a |fdbcd3ffc19c7646fbf77b96bf1
                   |94                          |e5

--- Comment #6 from Alex Merry <alex.me...@kde.org> ---
Git commit fb4d91996affdbcd3ffc19c7646fbf77b96bf1e5 by Alex Merry.
Committed on 30/11/2015 at 14:07.
Pushed by alexmerry into branch 'master'.

Make sure we load translations on the main thread.

Because the old implementation (accidentally) worked when you put the
ecm_create_qm_loader call in a different CMakeLists.txt file to the
target the file was added to, some projects did this.

This won't work with build-time-generated files, though, like moc files.
So we (ab)use QTimer events to make the loading happen on the main
thread.
REVIEW: 126000

M  +12   -5    modules/ECMPoQmTools.cmake
M  +67   -26   modules/ECMQmLoader.cpp.in
M  +42   -2    tests/ECMPoQmToolsTest/CMakeLists.txt
M  +3    -0    tests/ECMPoQmToolsTest/check.cmake.in
M  +2    -0    tests/ECMPoQmToolsTest/check_conf.cmake.in
A  +69   -0    tests/ECMPoQmToolsTest/tr_thread_test.cpp     [License: UNKNOWN]
 *
A  +12   -0    tests/ECMPoQmToolsTest/tr_thread_test_module.cpp     [License:
UNKNOWN]  *

The files marked with a * at the end have a non valid license. Please read:
http://techbase.kde.org/Policies/Licensing_Policy and use the headers which are
listed at that page.


http://commits.kde.org/extra-cmake-modules/fb4d91996affdbcd3ffc19c7646fbf77b96bf1e5

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to