Hi Nils,
Likely you have something missing in the header or parent header that's
expected. I would look at the difference in payload between the ipython
kernel and the magma kernel. In particular:
from IPython.display import HTML
> HTML('<a href="{https://localhost:8080/foo}"; target="magma_help">Magma
> help on FOO</a>')
produces on an ipython notebook client:
1. buffers: []
2. channel: "iopub"
3. content: {data: {text/plain: "<IPython.core.display.HTML object>",…},
metadata: {}, execution_count: 2}
1. data: {text/plain: "<IPython.core.display.HTML object>",…}
1. text/html: "<a href="{https://localhost:8080/foo}";
target="magma_help">Magma help on FOO</a>"
2. text/plain: "<IPython.core.display.HTML object>"
2. execution_count: 2
3. metadata: {}
4. header: {version: "5.3", date: "2019-04-22T20:08:39.525031Z",
session: "dda6906b-07b8f6043ea3f36416561134",…}
1. date: "2019-04-22T20:08:39.525031Z"
2. msg_id: "22771259-692e45452b81ef4b1ebb33e0"
3. msg_type: "execute_result"
4. session: "dda6906b-07b8f6043ea3f36416561134"
5. username: "mseal"
6. version: "5.3"
5. metadata: {}
6. msg_id: "22771259-692e45452b81ef4b1ebb33e0"
7. msg_type: "execute_result"
8. parent_header: {msg_id: "f7426ab80bd1418680290b7cad9578cc", username:
"username",…}
1. date: "2019-04-22T20:08:39.507312Z"
2. msg_id: "f7426ab80bd1418680290b7cad9578cc"
3. msg_type: "execute_request"
4. session: "cb6c03c40bf34b2d94f4468d5202cfb2"
5. username: "username"
6. version: "5.2"
You likely need to check if the client is receiving a similar message. You
can actually test the exact message and test how it would be interpreted by
the protocol you can monkey patch
https://github.com/jupyter/nbconvert/blob/master/nbconvert/preprocessors/execute.py#L531
and
run `nbconvert --execute my_magma_nb.ipynb` to see what message is received
and how it gets processed. See if this can reveal how the kernel is acting
differently. I can help advise how to make your payload be accepted as
expected in nbconvert if there's differences that aren't clear or
confusing. Comparing payload between ipython kernel and new kernel work is
a good starting point.
Best,
Matt
On Fri, Apr 19, 2019 at 9:01 PM Nils Bruin <[email protected]> wrote:
> First of all many thanks for developing and maintaining the excellent
> Jupyter software.
>
> For the IPython kernel https://github.com/nbruin/magma_kernel I am
> noticing a difference in behaviour between Jupyter Lab and Notebook for the
> handling of a display_data message with text/html data.
>
> The kernel handles certain responses with with following code, which is
> supposed to display an HTML link (to online help):
>
> def do_help(self, keyword):
> URL="http://system/online_help.html?query="+keyword
> content = {
> 'source': 'stdout',
> 'data': {
> 'text/html':'<a href="{}" target="magma_help">Magma help
> on {}</a>'.format(URL,keyword)
> }
> }
> self.send_response(self.iopub_socket, 'display_data', content)
>
> In Jupyter Notebook this works as expected. In Lab it doesn't display
> anything at all. Any suggestions on how I should change this code so that
> it works on Lab as well?
>
> Kind regards,
>
> Nils Bruin
>
> --
> You received this message because you are subscribed to the Google Groups
> "Project Jupyter" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> To post to this group, send email to [email protected].
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jupyter/10396a1e-2cb7-4365-ae03-60c87953b830%40googlegroups.com
> <https://groups.google.com/d/msgid/jupyter/10396a1e-2cb7-4365-ae03-60c87953b830%40googlegroups.com?utm_medium=email&utm_source=footer>
> .
> For more options, visit https://groups.google.com/d/optout.
>
--
You received this message because you are subscribed to the Google Groups
"Project Jupyter" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jupyter/CAJF6vz5VBxiYXZCE1wKN4w4FpQ8uRx4Qj1AppE%2B4GqYFjKuQWA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
