Thanks. I forked the github repo and rebased my changes on it. Finding all of the dependencies seems to go a lot better. But now I have this build issue when I try to do mvn package -P release. You can see that the file it builds and the name it later looks for are not quite the same.
[INFO] --- maven-jar-plugin:2.6:jar (default-jar) @ OpenJUMP --- [INFO] Building jar: /home/user/openjump-git/openjump/target/OpenJUMP-0.0.0-47f003a.jar [INFO] [INFO] --- maven-jar-plugin:2.6:jar (nolang) @ OpenJUMP --- [INFO] Building jar: /home/user/openjump-git/openjump/target/nolang/OpenJUMP-0.0.0-47f003a-nolang.jar [INFO] [INFO] --- maven-jar-plugin:2.6:jar (nosrc) @ OpenJUMP --- [INFO] Building jar: /home/user/openjump-git/openjump/target/nolang/OpenJUMP-0.0.0-47f003a-nosrc.jar [INFO] [INFO] --- maven-assembly-plugin:2.4:single (release core) @ OpenJUMP --- [INFO] Reading assembly descriptor: etc/mvn/bin_zip-core_stable.xml [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 42.626 s [INFO] Finished at: 2021-04-27T13:10:56+00:00 [INFO] Final Memory: 108M/4316M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.4:single (release core) on project OpenJUMP: Failed to create assembly: Error adding file to archive: /home/user/openjump-git/openjump/target/nolang/OpenJUMP-OpenJUMP-0.0.0-r47f003a-nosrc.jar isn't a file. -> [Help 1] Thanks, Jason ________________________________ From: edgar.sol...@web.de <edgar.sol...@web.de> Sent: Sunday, April 18, 2021 11:48 AM To: Jason Arnold <jarn...@ocient.com>; OpenJump develop and use <jump-pilot-devel@lists.sourceforge.net> Subject: Re: [JPP-Devel] Adding support for Ocient DB hi Jason, see my answers inline. On 18.04.2021 18:15, Jason Arnold wrote: > Hi all, > > My name is Jason Arnold. I'm an architect at a startup company called Ocient > that has built a distributed relational database for large scale analytics. > We recently added GIS support to our database, and I'm looking at 3rd party > tools that we can integrate with. > > So, I grabbed your source code, and it is amazingly easy to add support for a > new database to your code. Thanks for making it so easy! good to hear! > It was basically a new datastore folder, copy the postgres code and edit. > Update ConnectionManagerPanel, add a nifty icon, and edit the default > plugins. Done. > > I have it working. I did some basic demos to prove that it works. See lovely > attached pictures. don't see no attachments. did you maybe forget to attach? > So, my next question is.... what is the process for getting my changes merged > to your mainline? while not properly documented, we are currently doing a major overhaul targeting a new major version OJ2. part of it is a move to git on github. so the best way to get your changes into OJ2 would be to branch https://github.com/openjump-gis/openjump , rebase your changes on it and setup a pull request. please accompany the pull request commit message by a statement verifying that you contribute it as licensed under GPLv2, as this is the license OJ is distributed with. also please list which dependencies your modification has (jars) and where and under which licenses these are available. > On a side note, it seems you are probably doing your maven builds without > ever clearing your maven cache. The pom file currently points to repos that > don't exist anymore and versions that don't exist anymore, and it took quite > a bit of surgery for me to get something that built. > you may find that the github pom is somewhat cleaner and should hopefully not point to dead mvn repos anymore. thanks a bunch.. ede
_______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
