> i prefer to have code that belongs together in one place
I personally prefer the same too.
On the other hand, keeping two separate packages can have some advantages,
just in case we sholud have problems with the copyright for
com/vividsolutions/jump (probably not considering the GPL but we don't know
in the future).
Other reason is that developers can have interest to keep a visibility for
their developent as a part of their job keeping own packages (and not the
traditional). I understand this point of view: OJ cannot survive if there
is not a valid passion or economic incentive or both.
Just to give an example of a newer improvement on OJ 1,10: if you would
have take the decision to put GeoJSON in a Soldin package, I would have
supported your decision.
The position in the middle: considering case by case. In the case of WMS, I
agree with Ede. There are other case that we should live the situation as
it is - like all the editing Toolbox tools and related classes: there
should be a benefit to have all in an unique packages order - but this just
warried me considering all the classes relations that I still find (the
snaptool option dilaog of a previous mail of mine is an example).
Considering the topic of this discussion, my question before was only
for WMSScaleStylePanel.java.
Thinking about to distinguish for not clear situations (for myself, of
coarse;-)
For the future, I will personally prefer to keep on improving org.openjump
class for newer elements and keep the old com.vividsolution for
modficataion improvemnts of vivid's older. I will adopt this method also
for plugins.
My 2 cents
2017-02-02 16:34 GMT+01:00 <edgar.sol...@web.de>:
> we should probably talk about placing classes in general. i prefer to have
> code that belongs together in one place.
> i don't recall an instance that i placed code under org.openjump , because
> when i added eg. something to wms and that was placed under
> com.vividsolutions, the additions went there as well.
>
> just because we are now OpenJUMP seems not to be a valid reason to make
> development harder on ourselfs by cluttering packages.
>
> what's your point of view? ..ede
>
>
> On 02.02.2017 16:26, Giuseppe Aruta wrote:
> > I agree with Ede. We didn't had any feedback if anything was working or
> not.
> > com/vividsolutions/jump/workbench/ui/plugin/wms/WMSScaleStylePanel.java
> > should probably moved to org/openjump/core/ui/plugin/wms (my fault....)
> >
> > 2017-02-02 13:45 GMT+01:00 <edgar.sol...@web.de <mailto:
> edgar.sol...@web.de>>:
> >
> > On 02.02.2017 13 <tel:02.02.2017%2013>:29, Michaël Michaud wrote:
> > > AddWMSQueryPlugIn
> > > No more used ?
> > >
> >
> > let's keep that for reference. we can deprecate it though. ..ede
> >
> > ------------------------------------------------------------
> ------------------
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> > _______________________________________________
> > Jump-pilot-devel mailing list
> > Jump-pilot-devel@lists.sourceforge.net <mailto:Jump-pilot-devel@
> lists.sourceforge.net>
> > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel <
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel>
> >
> >
> >
> >
> > ------------------------------------------------------------
> ------------------
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> >
> >
> >
> > _______________________________________________
> > Jump-pilot-devel mailing list
> > Jump-pilot-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
> >
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
