Mike,
i just refined the errorhandling r5142 and fixed the NPE you mentioned. thx for
pointing that out! ..ede
On 02.11.2016 15:02, Michaud Michael wrote:
> OK, I'll check your change tonight, thanks,
>
>
>
> Michaël
>
> De : edgar.sol...@web.de
>
> Date d'envoi : mercredi 2 novembre 2016 à 14h47
>
> A : OpenJump develop and use <jump-pilot-devel@lists.sourceforge.net>
>
> Objet : Re: [JPP-Devel] Fwd: [jump-pilot:bugs] #438 Close openjump without
> saving project
>
> Mike, you mean WorkbenchFrame.log(...)? the missing t should be the reason
> that it does not print a stack.
>
> i guess what i wanted to achieve was some backward compatible info logging.
> level info shouldn't print stacks, so it is ignored. but let me fix it as
> ignore or use it, depending on the log level. similar to eg. I18N line 167
> Logger.warn(msg, Logger.isDebugEnabled() ? e : null);
>
> ok, i finetuned the errorhandling in r5140.
>
> d'accord? ..ede
>
> On 01.11.2016 11:55, Michaël Michaud wrote:
>> Hi Ede,
>>
>> In LayerManager, we have
>>
>> private void log(String message, Throwable t, StackTraceElement calledFrom) {
>> Logger.log(message, null, Level.INFO, calledFrom);
>> }
>>
>> Is it a typo or is there any reason to pass null instead of t to Logger ?
>> This is the origin of the NPE in #438
>>
>> Michaël
>>
>>
>>
>> -------- Message transféré --------
>> Sujet : [jump-pilot:bugs] #438 Close openjump without saving project
>> Date : Tue, 01 Nov 2016 10:48:25 +0000
>> De : michael michaud
>> Répondre à : Ticket 438
>> Pour : Ticket 438
>>
>>
>>
>> ------------------------------------------------------------------------
>>
>> *[bugs:#438] <https://sourceforge.net/p/jump-pilot/bugs/438/> Close openjump
>> without saving project*
>>
>> *Status:* open
>> *Created:* Tue Nov 01, 2016 10:48 AM UTC by michael michaud
>> *Last Updated:* Tue Nov 01, 2016 10:48 AM UTC
>> *Owner:* nobody
>>
>> Between 1.8 and 1.9, a prompt has been added to save the project in case the
>> user try to close OpenJUMP without saving it.
>> On a new project (never saved), the 1.8 version seems to do nothing (the
>> project is not saved), while from r4758 (adapt to new logger, we get a NPE
>> due to a "" argument changed int a null).
>>
>> More over, if we do several times the operation, we now have new Save
>> project menu items added in the file menu !
>>
>> ------------------------------------------------------------------------
>>
>> Sent from sourceforge.net because you indicated interest in
>> https://sourceforge.net/p/jump-pilot/bugs/438/
>>
>> To unsubscribe from further messages, please visit
>> https://sourceforge.net/auth/subscriptions/
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Developer Access Program for Intel Xeon Phi Processors
>> Access to Intel Xeon Phi processor-based developer platforms.
>> With one year of Intel Parallel Studio XE.
>> Training and support from Colfax.
>> Order your platform today. http://sdm.link/xeonphi
>>
>>
>>
>> _______________________________________________
>> Jump-pilot-devel mailing list
>> Jump-pilot-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>
>
> ------------------------------------------------------------------------------
> Developer Access Program for Intel Xeon Phi Processors
> Access to Intel Xeon Phi processor-based developer platforms.
> With one year of Intel Parallel Studio XE.
> Training and support from Colfax.
> Order your platform today. http://sdm.link/xeonphi
> _______________________________________________
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
