On 28.12.2015 13:38, Nicolas Ribot wrote: >> >>> Had some difficulties to find the right place to intercept errors, >>> especially because WHERE clause is tested only after the selected layers >>> are added to list of layers. >> >> how about adding the layer just after the featurecollection was created >> and added to it successfully, not before? >> > > I did not feel confident enough with my Java and OJ understanding to touch > these parts of the code :) >
when in doubt, research and suggest some changes here on the list. your approach to be careful when approaching internals is totally correct. >> >>> There are also 2 kinds of errors that can occur: >>> • A wrong WHERE clause is entered for a datasource >>> • A bad database layout, invalid DB types or other SQL-related error: in >>> this case, the layer is already added to OJ, with just a warning >> displayed >>> in the status bar: the layer is invalid, but still there in layer panel. >>> One have to manually remove it. >> >> see above >> >>> I think a more visible error handling would be valuable: like an error >>> message popup. >> >> ideally, the workframe errorhandler popup should be shown and the wizard >> should stay open to fix it. >> >> >> > Yes, should be the right handling. I will look at it. > thanks.. ede ------------------------------------------------------------------------------ _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
