On 24.12.2015 13:34, Alberto De Luca wrote: > Hi. > > @Ede > 1) that is something added by eclipse ( > http://stackoverflow.com/questions/654037/what-does-non-nls-1-mean). I took > it away from the WMS-related files, but you will find it in several other > files.
aren't you using netbeans? i see that those "//$NON-NLS-1$" were committed from your part https://sourceforge.net/p/jump-pilot/code/4663 just removed a heap of them project-wide. can you disable this "feature" on your side? > 2) yes, changing the API of TaskFrame wasn't brilliant... I reverted to > it's original state. For the neat implementation of InfoRequest, it will be > done, but I need some more time. "not brilliant" being an understatement i perceive ;) wrt. the API - we have to doublecheck each other. especially very central classes can not be API changed without some extensions out there getting incompatible. wrt. InfoRequest - please do so to keep OJ as clean as possible :).. you probably want to enhance AbstractBasicRequest as it currently only sports a getImage() method. > @Jukka > I changed the method used to retrieve the url as you suggested. I added the > FEATURE_COUNT=10 parameter, and I limited the WMS info to the visible > layers. Not visible and selected, just visible, to make it consistent with > vector layers. sounds reasonable. > Alberto > > On 24 December 2015 at 13:02, <edgar.sol...@web.de> wrote: > >> hey Alberto, >> >> i have some questions/comments >> >> 1. >> in several files eg. Parser.java you added lines ending with >> '//$NON-NLS-1$' . why? >> >> 2. >> you insert wms code (url appending) directly into the featureinfotool up >> to the point that it even runs the web request. >> why don't you use the wms package? i see you added the info url to the >> capabilities already. would you mind implementing that cleanly with a >> InfoRequest object along the lines of existing MapRequest.java . this way >> you can reuse all the magic there is already including auth/proxy usage. >> changing the API of TaskFrame to an IOException throwing getInfoFrame() is >> an absolute no go from my point of view. >> >> how long would it take for you to fix it? keep in mind, we can easily slip >> in a clean version with the first maintenance release. so no hurry. >> >> ..ede >> >> >> On 24.12.2015 00:18, Alberto De Luca wrote: >>> Right sorry, >>> >>> I think Parser.java was the culprit. I had deleted it locally, but not on >>> the server. It is no longer needed actually, but instead of deleting it I >>> edited to make it compatible with the modified WMS classes (so we can >> keep >>> it, you never know...). >>> >>> Apparently it builds now, let me know. >>> Alberto >>> >>> On 23 December 2015 at 22:00, <edgar.sol...@web.de> wrote: >>> >>>> Alberto, >>>> >>>> your commit seems incomplete.. ede >>>> >>>> >>>> On 23.12.2015 18:28, Rahkonen Jukka (MML) wrote: >>>>> Hi, >>>>> >>>>> r4663 did not build >>>>> >>>> >> http://sourceforge.net/projects/jump-pilot/files/OpenJUMP_snapshots/OpenJUMP-20151223-r4663.log/download >>>>> >>>>> -Jukka Rahkonen- >>>>> >>>>> >>>>> -----Alkuperäinen viesti----- >>>>> Lähettäjä: jump-pilot-...@lists.sourceforge.net [mailto: >>>> jump-pilot-...@lists.sourceforge.net] >>>>> Lähetetty: 23. joulukuuta 2015 18:27 >>>>> Vastaanottaja: jump-pilot-devel@lists.sourceforge.net >>>>> Aihe: [JPP-Devel] SVN: [4663] core/trunk >>>>> >>>>> Revision: 4663 >>>>> http://sourceforge.net/p/jump-pilot/code/4663 >>>>> Author: bertazza >>>>> Date: 2015-12-23 16:26:41 +0000 (Wed, 23 Dec 2015) >>>>> Log Message: >>>>> ----------- >>>>> Info feature tool: added a pane to show WMS info. >>>>> >>>>> Modified Paths: >>>>> -------------- >>>>> core/trunk/ChangeLog >>>>> core/trunk/src/com/vividsolutions/jump/workbench/ui/InfoFrame.java >>>>> >>>> >> core/trunk/src/com/vividsolutions/jump/workbench/ui/PrimaryInfoFrame.java >>>>> core/trunk/src/com/vividsolutions/jump/workbench/ui/TaskFrame.java >>>>> >>>> >> core/trunk/src/com/vividsolutions/jump/workbench/ui/cursortool/FeatureInfoTool.java >>>>> core/trunk/src/com/vividsolutions/wms/AbstractParser.java >>>>> core/trunk/src/com/vividsolutions/wms/Capabilities.java >>>>> core/trunk/src/com/vividsolutions/wms/MapLayer.java >>>>> core/trunk/src/com/vividsolutions/wms/ParserWMS1_0.java >>>>> core/trunk/src/com/vividsolutions/wms/ParserWMS1_1.java >>>>> core/trunk/src/com/vividsolutions/wms/ParserWMS1_3.java >>>>> core/trunk/src/com/vividsolutions/wms/WMService.java >>>>> core/trunk/src/org/openjump/core/ui/plugin/queries/QueryDialog.java >>>>> >>>>> Added Paths: >>>>> ----------- >>>>> >>>> >> core/trunk/src/com/vividsolutions/jump/workbench/ui/cursortool/clean.xsl >>>>> core/trunk/src/com/vividsolutions/wms/MapStyle.java >>>>> SNIP ------------------------------------------------------------------------------ _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
