On 10.11.2013 19:47, Michaël Michaud wrote:
> Hi Ede,
> 
> Sorry for the lack of feedback. You've done a big work !

yeah, quite a bit more than expected initially

> I can see several benefits :
> - from a user point of view, it will make OJ much more configurable.
> It is not a very important point for me, but I know many users like to
> customize the UI.
> - from a developper point of view, I'm sure that this kind of refactoring
> is good to update old code and make things more consistent. Also it may
> be a good starting point to go further toward a external plugins manager ;-)

was on e of the incentives although now i feel like it being more a template 
configuration for OJ menus. the internal loading routines though are much more 
unified now so that e.g. a real time en/disabling plugins, add/removing of menu 
item comes into reach.

> I've also some questions and some concerns :
> - about xml schema : the way xml is organized is a bit puzzling as it 
> does not
> reflect the menu hierarchy but the order menu items / separator are added
> to the menubar. I don't say it is not fine, but quite different the way 
> I could
> have imagine it (and different from the way xml frameworks to create UI
> work).

result of the approach to stay backward compatible. also, i just freestyled ;) 
.. i tried to accomplish a configuration that allows 
- defining menu order
- defining menu attributes (icon, separators, names)
- installation or initialization like they were defined in the configurations 
before

> - I haven't checked yet what the install attribute means

it simply installs the plugin into the menu defined analogue to the initialize 
attribute. you can leave out the addMainMenuPlugin() call in initialize and 
simply do it via xml now. you can see it as an alternative to using add*Menu() 
in the initialize method of the plugin.

> - wonder if we could have completely avoid name attribute (mainly managed
> in language file)

you can, but i included it for us to be able to have full control over third 
party plugins. idea is to have full control over plugins! we can completely 
reroute/modify their menu entry now without changing a line of code in their 
sources.
rationale is to get rid of the Plugins main menu (in PLUS) and integrate it's 
entries in Tools and wherever it fits most perfectly. looking forward to 
suggestions and or initiatives (looking at you Peppe ;). all you have to do is 
simply add a plugin entry into default-plugins.xml at the position wanted with 
a menu tag and a fixed menupath attribute, et voila!

..ede

PS. i probably should add a documentation at the top of the xml file describing 
known tags and parameters a bit. will keep it in  mind!

> 
> Michaël
> 
> Thanks for the effort. I haven't tested the benefits yet as something 
> more configurable is
>> On 10.11.2013 18:34, micha...@users.sourceforge.net wrote:
>>> Update default-plugins.xml to include new postgis driver
>> btw. any comments on the xml changes? ..ede
>>
>> ------------------------------------------------------------------------------
>> November Webinars for C, C++, Fortran Developers
>> Accelerate application performance with scalable programming models. Explore
>> techniques for threading, error checking, porting, and tuning. Get the most
>> from the latest Intel processors and coprocessors. See abstracts and register
>> http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
>> _______________________________________________
>> Jump-pilot-devel mailing list
>> Jump-pilot-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>>
>>
> 
> 
> ------------------------------------------------------------------------------
> November Webinars for C, C++, Fortran Developers
> Accelerate application performance with scalable programming models. Explore
> techniques for threading, error checking, porting, and tuning. Get the most 
> from the latest Intel processors and coprocessors. See abstracts and register
> http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
> _______________________________________________
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
> 

------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most 
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Reply via email to