looks promising over coffee on a first glance.. two minor issues though. 1. seems like your patch contains whitespace changes only. see eg. changes to AbstractSaveProjectPlugIn.java . this is no big issue, but could you make sure that these are there to streamline spacing. eg. if the code was mixed tabs/spaces before which you corrected or you changed something in a method that this method is either tab _or_ space indented now. generally we prefer space indention, but of course wont refuse new classes fully tab indented. wrt. legacy code - as reformatting whole classes on commits to fixup formatting would obfuscate the real changes of a commit we usually restrict reformatting to changed code areas.
2. bellow sounds like a german dog name ;).. please use http://dict.leo.org/?lp=ende&search=below instead at least for the translations visible to the user. ..ede On 09.09.2013 03:13, Matthias Hinz wrote: > Just a small update on the patch because of a faulty German Umlaut in the > translation. > > Am 09.09.2013 01:26, schrieb Matthias Hinz: >> Dear all, >> >> I changed my solution according to the latest discussion and it works >> without obstacles, as far as I tested. Also there is a screenshot which asks >> if paths should be updated. >> For "no" the program works like before, for "yes" 'all' file path bellow the >> project directory will be rebased. It is possible to limit this action to >> missing resources. >> If one of the resources does not exist in its new location, the known >> filechooser dialog pops up. >> >> I'm just a little unsure about the dialog text. Is it self-explaining? I >> added German translation as well. With the other languages I'm not yet firm >> enough :). >> >> Matthias ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
