Hi, Nice work Ede, thanks a lot.
Michaël > On 31.03.2012 16:29, Michaël Michaud wrote: >> Hi, >>> we could disable the icons conditionally for windows laf and win7+ as other >>> lafs and platforms are not hit. >> Agree if you do it ;-) > done > >> I will open a bug report which will stay opened as long as the bug is >> not fixed in jre. > beat you to it ;) > >> I had a quick look in the menus and noticed also >> - a icon + check symbol in category context menu (change visibility) >> - a icon + check symbol for View> Edit toolbox menuitem >> I suppose they are also concerned by the bug, which means there are at >> least 4 menu-items to fix. >> > it's worked around generically where the menuitems are generated. i also did > some housekeeping while at it. here's the commit message > > Revision: 2786 > http://jump-pilot.svn.sourceforge.net/jump-pilot/?rev=2786&view=rev > Author: edso > Date: 2012-04-02 13:14:37 +0000 (Mon, 02 Apr 2012) > Log Message: > ----------- > bugfix: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7122141 > > http://www.mail-archive.com/jump-pilot-devel@lists.sourceforge.net/msg10601.html > > com.vividsolutions.jump.workbench.ui.plugin.FeatureInstaller > - unified spaces/tabs, general reformatting > - privatized internally used behead method > - deprecated legacy methods addLayerViewMenuItem(), addLayerNameViewMenuItem() > - added replacement method for deprecated addMainMenuItem to add plain > plugins: > addMainMenuPlugin( PlugIn, menuPath, menuItemName, checkBox, icon, > enableCheck, pos), > former changes by michael added methods for JMenuItem and AbstractUiPlugIn > only > - added addMenuItemIcon() method used by all methods that add menu entries to > popup/mainmenu > it contains a workaround for the windows laf missing checkmark ticks for > checkbox entries on vista and later > - cleaned up addPopupMenuItem() method that duplicated routines > - commented (pending deletion) addMainMenuItemWithJava14Fix() methods > classes using the method above modified to use addMainMenuItem() > > ..ede > > ------------------------------------------------------------------------------ > This SF email is sponsosred by: > Try Windows Azure free for 90 days Click Here > http://p.sf.net/sfu/sfd2d-msazure > _______________________________________________ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > > ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
