Hi Uwe, OK, I spent some time in ColorThemingStylePanel code, and tried to improve/clean it. I made several modifications : - now, the attribute selection decides which classification method is available (before, it was the opposite : classification choice could change the selected attribute, which, in my opinion, was not the right way). - user interface appearance has been slightly changed (homogeneization of label case and alignments) - when a theming has been applied and the user reopen the color theming panel, some options are preserved.
Hope this also solves the problem you mentioned. There are still two small problem I did not resolve. - I wanted to limit attribute name combobox to a max size but could not find the right place to do it. Not a problem except with very long attribute names. - reopening the dialog after a classification has been applied : If a range-based classification was applied, the dialog display equal-interval method whatever the range-based method was (method is not saved in the Style object, only color mapping is saved). Before my changes, I think that the dialog always displayed the single-value method, whatever the previous classification method was. Hope I did not introduce new bugs. Please test with next NB. I will not have time to package a 4.3.2 version right now. Hope to do it by the end of August. Michaël Le 26/07/2011 08:48, Uwe Dalluege a écrit : > Good morning Michaël, > > great! This bug is fixed. Thank you! > But there is (for my opinion) a little strange behavior. > Now my test-layer has four attributes in this order: > name (String), name1 (String), ivalue (Integer) > and dvalue (Double) and I filled them with values. > > 1. Choose Unique value and dvalue. > Everything is all right! > > 2. Now choose Equal Interval. > The Attribute switches from dvalue to ivalue > (I think to the first possible attribute) > > It seems, if you change the Classification Method > the Attribute changes to the first possible attribute. > > This is a little confusion because if you change > the Classification Method you also have > to change the Attribute again. > You can not test all Classification Methods with, > for example, dvalue because dvalue is the last Attribute > and ivalue (or "name" with Unique value) > appears in the Attribute-Combo Box. > > > In the standard Window LookAndFeel the Combo Box for > the Atrribute is too small. The attribute "name" > (four letters) appears with n... > > What do you think about the spelling of "Unique value"? > The token "value" starts with small letter > but Interval from Equal Interval starts with capital letter. > I think "Unique Value" is better, what do you think? > > > So much words about little problems ;-) > I hope you have nice weather in Paris. > Greetings from Hamburg to Paris (today with sunny weather) :-) > > > Uwe > > > > Am 25.07.2011 22:37, schrieb Michaël Michaud: >> Le 25/07/2011 08:13, Uwe Dalluege a écrit : >>> Hi Michaël, >>> >>> I have tested it with OJ 1.4.0.3, 1.4.1 >>> and with the nightbuild 1.4.2 alpha. >>> But OJ does *not* throws an exception in my tests! >> It does in the console (which is hidden by default) >> >> I think I fixed the bug (check next NB), >> but ColorThemingStylePanel class is quite complex, >> so your tests are always welcome :-) . >> >> Michaël >>> >>> The layer contains only one string-attribute (name). >>> >>> You are right: You can not switch to Equal Interval >>> because the combo box shows Unique value again >>> (see step 7). Maybe this is correct because you have >>> no equal intervals with string-attributes. >>> But then the attribute-combo box is empty again. >>> If you choose the attribute "name" again, nothing happens. >>> >>> Regards, >>> >>> Uwe >>> >>> Am 24.07.2011 12:37, schrieb Michaël Michaud: >>>> Hi Uwe, >>>> >>>> I agree there is still a problem with Colour Theming user interface, >>>> and to start with, OpenJUMP throws an exception as soon as the >>>> colour theming is enable because no attribute is selected at this >>>> time. >>>> >>>> That said, I cannot reproduce your steps. After 6, I cannot switch to >>>> Equal Intevall. If I try to do it, the combo box still display the >>>> Unique Value option. >>>> Can you tell me which OJ version you test and if your layer contains >>>> only >>>> name attribute ? >>>> >>>> Michaël >>>> >>>> Le 22/07/2011 12:21, Uwe Dalluege a écrit : >>>>> Hi, >>>>> >>>>> I have a problem with Color Theming: >>>>> >>>>> 1. Create a new project. >>>>> >>>>> 2. Draw two polygons. >>>>> >>>>> 3. View/Edit Schema with >>>>> Fieldname "name" and Data Type String >>>>> >>>>> 4. View/Edit Attributes and give the attribute "name" >>>>> the values A and B >>>>> >>>>> 5. Color Theming>Enable color theming >>>>> (The Attribute combobox is empty). >>>>> >>>>> 6. Choose the attribute "name" and >>>>> Classification Method: Unique value. >>>>> Everything is all right! >>>>> >>>>> 7. Now choose Equal Intervall. >>>>> The Attribute combobox is empty >>>>> and the Classification Method is Unique value. >>>>> >>>>> 8.Choose Attribute "name" but nothing happens!!! >>>>> There are no attribute-colors. >>>>> >>>>> Regards, >>>>> >>>>> Uwe >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> >>>>> >>>>> >>>>> 10 Tips for Better Web Security >>>>> Learn 10 ways to better secure your business today. Topics covered >>>>> include: >>>>> Web security, SSL, hacker attacks& Denial of Service (DoS), private >>>>> keys, >>>>> security Microsoft Exchange, secure Instant Messaging, and much more. >>>>> http://www.accelacomm.com/jaw/sfnl/114/51426210/ >>>>> _______________________________________________ >>>>> Jump-pilot-devel mailing list >>>>> Jump-pilot-devel@lists.sourceforge.net >>>>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel >>>>> >>>>> >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> >>>> >>>> >>>> Magic Quadrant for Content-Aware Data Loss Prevention >>>> Research study explores the data loss prevention market. Includes >>>> in-depth >>>> analysis on the changes within the DLP market, and the criteria >>>> used to >>>> evaluate the strengths and weaknesses of these DLP solutions. >>>> http://www.accelacomm.com/jaw/sfnl/114/51385063/ >>>> _______________________________________________ >>>> Jump-pilot-devel mailing list >>>> Jump-pilot-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel >>> >>> >> > > ------------------------------------------------------------------------------ Got Input? Slashdot Needs You. Take our quick survey online. Come on, we don't ask for help often. Plus, you'll get a chance to win $100 to spend on ThinkGeek. http://p.sf.net/sfu/slashdot-survey _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
