Hi Matthias,

  I had some problems applying the patch.  I was only able to get the
AbstractSelectionRenderer and OptionsPlugIn patches.  Eclipse wouldn't
create the new files for some reason.

  Looking at the changes to AbstractSelectionRenderer, I do have some
concerns about efficiency since I have recently made changes there to speed
things up.  I suggest that you move references to the blackboard outside of
AbstractSelectionRenderer, and add vertexStyle as a class variable settable
by a public set method.  You should probably have a default constructor for
VertexStyle that gives the legacy behavior.

You should be able to call repaint() from LayerViewPanel.

regards,
Larry Becker

On Fri, Jun 18, 2010 at 3:43 PM, Matthias Scholz <m...@jammerhund.de> wrote:

> Hi,
>
> the attached patch are a first version of my selectionstyle enhancement.
> You can change the selectionstyle with a new tab in the optionsdialog. The
> stylings are stored in the persistent Blackboard -> workbench-state.xml.
>
> Please take a look at my code and tell me your opinion. It would be nice if
> you can integrate the code into the project.
>
> Can anybody tell me how i can do a "repaint" after the OK button was
> pressed(SelectionStyllingOptionsPanel.okPressed()). In the actual version
> you must move or zoom the map that you see the new styling setting. It would
> be better if you see the changes immediately.
>
> Matthias
>
>
>
> ------------------------------------------------------------------------------
> ThinkGeek and WIRED's GeekDad team up for the Ultimate
> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
> lucky parental unit.  See the prize list and enter to win:
> http://p.sf.net/sfu/thinkgeek-promo
> _______________________________________________
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>
>
------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate 
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
lucky parental unit.  See the prize list and enter to win: 
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Reply via email to