Hi Uwe,

I just add a where clause to PostGISPlugin in the repository if you want to
teste it and made some remark?
Thanks.

i have to plan to add fonctionnality :
Update some fields in table with a given key.

Just a question : all properties in DataSourceQuery instance is DataSource
responsability ?
and when I build a PostGISDataSourceQuery with fully qualified
PostGISDatasource.
I can't get a PostGisconnection is it a normal beavior?

ie :
PostGISDataSource pgDS = new PostGISDataSource();
properties = new HashMap();
 ... set properties key
pgDS.setProperties(properties);

pgQuery = new PostGISDataSourceQuery(pgDS,query,layerName);

// don't work
pgQuery.getDataSource().getConnection().executeQuery(query);


What do you think about this modification in PostGISDataSourceQuery?

  /**
   * Returns the DataSource for the query.
   */
  public DataSource getDataSource()
  {
    // FIXME:[eric.lemesre] maintain Porperties is DataSource
responsability?
    //ds.setProperties(properties);
    DataSource ds = super.getDataSource();
    return(ds);
  }

  /**
   * Property map for the query object. For defined keys see: [EMAIL PROTECTED]
PostGISDataSource}
   */
  public void setProperties(HashMap properties) {
    // FIXME:[eric.lemesre] maintain Porperties is DataSource
responsability?
    //this.properties = (HashMap)properties.clone();
    getDataSource().setProperties((HashMap)properties.clone());
  }
}

It work but is it best practice?

See U
Eric

2007/10/15, Uwe Dalluege <[EMAIL PROTECTED]>:
>
> Hi Eric,
>
> the version number 6.11.6B means that I have changed thist
> PlugIn at 2006.11.6. B means beta. This notation is from me.
> I think 1.2.0 is from Stefan.
>
> Regards
>
> Uwe
>
> Eric Lemesre schrieb:
> > Hi Stefan,
> >
> > Ok but I think the better way is commit initial code
> > (the 6.11.6B) and after commit modification.
> >
> > the code for OpenFile framework is in package :
> > com.vividsolutions.jump.workbench.datasource ?
> >
> > @Uwe : please can you give me more explanation about version number ?
> >
> > internal version is 6.11.6B and jar version is 1.2.0 ??
> >
> > Thanks
> > Eric
> >
> > 2007/10/12, Stefan Steiniger <[EMAIL PROTECTED] <mailto:
> [EMAIL PROTECTED]>>:
> >
> >     Hei Eric,
> >
> >     I have created a new PostGisPlugin Folder on the SVN.
> >     Can you commit your modified Postgisplugin code to that folder
> >     (trunk/src)? If this is done we can then modify the postgisplugin
> >     sources to work with the new OpenFile framework
> >
> >     stefan
> >
> >     Eric Lemesre schrieb:
> >      > Hi Stefan,
> >      >
> >      > Thank for your intervention with Uwe,
> >      > I rebuild directory structure and commit in a new directory this
> >     plug in.
> >      >
> >      > probebly befor this WE.
> >      >
> >      > Eric
> >      >
> >      > 2007/10/8, Stefan Steiniger < [EMAIL PROTECTED]
> >     <mailto:[EMAIL PROTECTED]> <mailto: [EMAIL PROTECTED]
> >     <mailto:[EMAIL PROTECTED]>>>:
> >      >
> >      >     Hei Eric,
> >      >
> >      >     Uwe agrees to put the postgis plugin on the svn.
> >      >     for the rest - because I never used maven - can you simple
> >     outline the
> >      >     directory structure on the SVN. So I have a better image what
> >     you want
> >      >     to do.
> >      >
> >      >     stefan
> >      >
>
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Reply via email to