Done ! Michaël
Sunburned Surveyor a écrit : >Why don't we add the method back with the deprecated tag. We can put a >comment in the source code file stating that the method can be removed >when the Pirol team makes the needed changes. > >The Sunburned Surveyor > >On 8/20/07, Michaël Michaud <[EMAIL PROTECTED]> wrote: > > >>Hi Sunburned, >> >>I have been in touch with Michael who has no much time to work on >>Pirol's plugin as he leaved the project. But he told me that he will try >>to make the change and that another guy will come on september. >>We can wait a little to see if Pirol's plugin is updated, or I can add >>the method back in LayerManager (nobody should use it but I can add it >>with a deprecated tag). >> >>Michael >> >>Sunburned Surveyor a écrit : >> >> >> >>>Will the Pirol team allow us to make the changes to their code if they >>>are too busy? >>> >>>The Sunburned Surveyor >>> >>>On 8/18/07, Michaël Michaud <[EMAIL PROTECTED]> wrote: >>> >>> >>> >>> >>>>Hei Michael (Brunig), >>>> >>>>A few month ago, I changed a method signature in OpenJUMP LayerManager's >>>>class to solve a problem with "cloned windows", but it has broken one >>>>(or more) pirol's plugin : >>>> >>>>The change : >>>>com.vividsolutions.jump.workbench.model.LayerManager.dispose(Layerable >>>>layerable) >>>>--> >>>>com.vividsolutions.jump.workbench.model.LayerManager.dispose(WorkbenchFrame >>>>frame, Layerable layerable) >>>> >>>>The reason : >>>>when one removes a layer from a task, I want this layer to be removed >>>> >>>> >>>>from all the cloned windows in this task, >>> >>> >>>>so I needed a reference to the frame. >>>> >>>>The break : >>>>in >>>>de.fhOsnabrueck.jump.pirol.plugIns.PirolRasterImage.RemoveSelectedRasterImageLayersPlugIn.remove(Layerable[] >>>>selectedLayers) >>>>the code use the old method in the following line >>>>selectedLayers[i].getLayerManager().dispose(selectedLayers[i]); >>>> >>>>It's quite straight to change it to use the new method (you have also to >>>>pass the PlugInContext to the method to have a reference to WorkbenchFrame) >>>> >>>>If you cannot do it, or don't want for any reason, I'll add the old >>>>method back to LayerManager, with a strong advice against its use. >>>> >>>>Sincerly, >>>> >>>>Michael (the french one) >>>> >>>> >>>> >>>> >>>>------------------------------------------------------------------------- >>>>This SF.net email is sponsored by: Splunk Inc. >>>>Still grepping through log files to find problems? Stop. >>>>Now Search log events and configuration files using AJAX and a browser. >>>>Download your FREE copy of Splunk now >> http://get.splunk.com/ >>>>_______________________________________________ >>>>Jump-pilot-devel mailing list >>>>Jump-pilot-devel@lists.sourceforge.net >>>>https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel >>>> >>>> >>>> >>>> >>>> >>>------------------------------------------------------------------------- >>>This SF.net email is sponsored by: Splunk Inc. >>>Still grepping through log files to find problems? Stop. >>>Now Search log events and configuration files using AJAX and a browser. >>>Download your FREE copy of Splunk now >> http://get.splunk.com/ >>>_______________________________________________ >>>Jump-pilot-devel mailing list >>>Jump-pilot-devel@lists.sourceforge.net >>>https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel >>> >>> >>> >>> >>> >>> >>------------------------------------------------------------------------- >>This SF.net email is sponsored by: Splunk Inc. >>Still grepping through log files to find problems? Stop. >>Now Search log events and configuration files using AJAX and a browser. >>Download your FREE copy of Splunk now >> http://get.splunk.com/ >>_______________________________________________ >>Jump-pilot-devel mailing list >>Jump-pilot-devel@lists.sourceforge.net >>https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel >> >> >> > >------------------------------------------------------------------------- >This SF.net email is sponsored by: Splunk Inc. >Still grepping through log files to find problems? Stop. >Now Search log events and configuration files using AJAX and a browser. >Download your FREE copy of Splunk now >> http://get.splunk.com/ >_______________________________________________ >Jump-pilot-devel mailing list >Jump-pilot-devel@lists.sourceforge.net >https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > > > > ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
