There is a lot of dead code that could be removed. I'm surprised that the ones on your list are no longer referenced, but it doesn't hurt to try.
Larry On 7/8/07, Stefan Steiniger <[EMAIL PROTECTED]> wrote: > > > Michaël Michaud schrieb: > > Hi, > > > > OK, I did not remember the ok button problem with mac osx. > > I thing there should be a solution without duplicating the plugins, but > > I have no mac to test. > > I'll have a deeper look in the code to try to understand. > > Mac users are welcome to make more tests with load and save features > > (from the source code or from nightly snapshot). > > If we find no better solution, I can re-activate the 'asFile' plugins > > before next official release (any date fixed). > > not that I know ;) > > > > > Another think about the driver/datasource api > > There is much more place for cleaning, due to the fact that the old > > driver api has been replaced by a new datasource api. > > I could remove more than 20 classes without modifying OpenJUMP's core > > behaviour (as far as I could see after only few tests). > > mhm.. lets try if Larry agrees > > stefan > > > Those classes seem no more used in the core of OpenJUMP > > jumptest.io.AbstractDriverPanelProxy > > com.vividsolutions.jump.workbench.driver.* (14 classes) > > com.vividsolutions.jump.workbench.ui.AbstractDriverPanel > > com.vividsolutions.jump.workbench.ui.BasicFileDriverPanel > > com.vividsolutions.jump.workbench.ui.DriverDialog > > com.vividsolutions.jump.workbench.ui.DriverPanelCache > > com.vividsolutions.jump.workbench.ui.FMEFileDriverPanel > > com.vividsolutions.jump.workbench.ui.GMLFileDriverPanel > > com.vividsolutions.jump.workbench.ui.JMLFileDriverPanel > > And those one have to be modified if the previous are removed > > com.vividsolutions.jump.workbench.plugin.PlugInContext > > com.vividsolutions.jump.workbench.JUMPWorkbench > > com.vividsolutions.jump.workbench.JUMPWorkbenchContext > > com.vividsolutions.jump.workbench.WorkbenchContext > > > > Here is the code with all this stuff removed if some of you want to make > > more tests or check if it works well with your plugins. > > http://geo.michaelm.free.fr/OpenJUMP/resources/OJ-dist-mm-20070707.zip > > > > Michaël > > > > Stefan Steiniger a écrit : > > > >> Salut Michael, > >> > >> i have seen your last commits (thanx for the changes). > >> > >> There is one thing to note: > >> The plugin seems to be necessary for MacOSX users, since the other > >> LoadDataset dialog does not show the "ok" button. Thus, before doing a > >> release we need to test the file-selection-dialog on OSX (I have - still > >> - a running osx). > >> I don't know if the "todo" file is already in use, but it seems to be > >> worth to add this there. could you do that? (i will see if I can do > >> today my first svn checkout) > >> > >> I will additionally add this on the OJ-wiki: > >> http://openjump.org/wiki/show/Future+Developments > >> > >> thanx, > >> stefan > >> > >> ------------------------------------------------------------------------- > >> This SF.net email is sponsored by DB2 Express > >> Download DB2 Express C - the FREE version of DB2 express and take > >> control of your XML. No limits. Just data. Click to get it now. > >> http://sourceforge.net/powerbar/db2/ > >> _______________________________________________ > >> Jump-pilot-devel mailing list > >> Jump-pilot-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > >> > >> > >> > >> > > > > > > ------------------------------------------------------------------------- > > This SF.net email is sponsored by DB2 Express > > Download DB2 Express C - the FREE version of DB2 express and take > > control of your XML. No limits. Just data. Click to get it now. > > http://sourceforge.net/powerbar/db2/ > > _______________________________________________ > > Jump-pilot-devel mailing list > > Jump-pilot-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > > > > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ > _______________________________________________ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > -- http://amusingprogrammer.blogspot.com/ ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
