Hei Sascha,

please commit!
and thanx for your participation (i think except larry there is no 
further "real" programmer on the project)

greetings from zurich,
stefan

Sascha L. Teichmann schrieb:
> Hi!
> 
> Not easy to find a accurate topic for this little bug.
> 
> If you store a project with an WMS layer in it and
> load this project later, the WMS layer is not loaded
> parallel any more.
> 
> Background: WMS layers are normally loaded in parallel
> running threads to compensate there slow data arrival.
> 
> To archive that the layers blackboard contains a
> special hint. This is done during layer construction.
> This hint is not serialized when the project is saved.
> When the project comes up again Java2XML calls a
> constructor that does not install this hint again.
> Therefore the WMS layer is treated like a normal
> layer with sequential data retrieval. This can be
> a significant slow down.
> 
> To reproduce this bug load a few layers from a
> WMS server (e.g. [1]) store a new project, restart OJ
> and load it. You will notice that the loading clock
> is not rotating and that the layers pop up one after the other
> slowly.
> 
> Find attached a patch against WMSLayer [2] that fixes this issue.
> 
> I did not find any entry in the issue tracker concerning this bug.
> If you don't tell me that this not a bug I will commit the patch
> to CVS.
> 
> Kind Regards,
>   Sascha
> 
> 
> [1] http://132.156.10.87/cgi-bin/atlaswms_en?REQUEST=GetCapabilities
> [2] com.vividsolutions.jump.workbench.model.WMSLayer
> 
> 
> ------------------------------------------------------------------------
> 
> Index: ./com/vividsolutions/jump/workbench/model/WMSLayer.java
> ===================================================================
> RCS file: 
> /cvsroot/jump-pilot/openjump/src/com/vividsolutions/jump/workbench/model/WMSLayer.java,v
> retrieving revision 1.3
> diff -u -r1.3 WMSLayer.java
> --- ./com/vividsolutions/jump/workbench/model/WMSLayer.java   22 May 2007 
> 18:11:40 -0000      1.3
> +++ ./com/vividsolutions/jump/workbench/model/WMSLayer.java   25 May 2007 
> 22:21:47 -0000
> @@ -79,6 +79,7 @@
>        * Called by Java2XML
>        */
>       public WMSLayer() {
> +             init();
>       }
>  
>       public WMSLayer(LayerManager layerManager, String serverURL, String srs,
> @@ -106,10 +107,14 @@
>               setSRS(srs);
>               this.layerNames = new ArrayList(layerNames);
>               setFormat(format);
> +             init();
> +             this.wmsVersion = version;
> +     }
> +
> +     protected void init() {
>               getBlackboard().put(
>                               
> RenderingManager.USE_MULTI_RENDERING_THREAD_QUEUE_KEY, true);
>               getBlackboard().put(LayerNameRenderer.USE_CLOCK_ANIMATION_KEY, 
> true);
> -             this.wmsVersion = version;
>       }
>       
>       private void setService(WMService service) {
> 
> 
> ------------------------------------------------------------------------
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Reply via email to