One option is to run the test suite with go 1.3 and just make sure that juju compiles with all the other compilers (1.2, gccgo, etc). That gives us a fast precommit check, which won't catch everything, but should catch most 1.2 compat bugs. And leave the full test suite runs as CI tests.
John =:-> On Thu, Mar 5, 2015 at 6:28 AM, Andrew Wilkins <[email protected] > wrote: > On Thu, Mar 5, 2015 at 10:24 AM, Tim Penhey <[email protected]> > wrote: > >> On 04/03/15 19:05, Andrew Wilkins wrote: >> > The bugs were fixed in this branch: >> https://github.com/juju/juju/pull/1738 >> > - invalid printf-style formatting will cause "go vet" to fail >> >> My bad. I had deleted the pre-push hook script some time ago when go vet >> failed continuously, and I hadn't reinstated it. >> >> I have done so now. >> > > Thanks. FYI (and others' I), there's a couple of ways to temporarily > disable hooks or just vet: > > git push --no-verify > or > IGNORE_VET_WARNINGS=1 git push > > (obviously to be used judiciously) > > -- > Juju-dev mailing list > [email protected] > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/juju-dev > >
-- Juju-dev mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
