The problem is that go get -u stomps on everything, and godeps doesn't do any fetching (you must already have the target revisions locally). Which means that potentially go get -u changes the tree we are testing. (You want a go get that updates all the dependencies, but not the main branch.)
It would be possible, but it isn't worth the time spent today, IMO. John =:-> On Mar 13, 2014 1:53 AM, "Tim Penhey" <tim.pen...@canonical.com> wrote: > It seems that I have mis-remembered and the bot has never done this, but > the CI process has. > > Can we make the bot do it please? > > Tim > > On 13/03/14 10:47, Tim Penhey wrote: > > Hi there, > > > > I tried to land a branch that updated the golxc version in our > > dependencies.tsv file. This used to work, and now the current bot > > doesn't do it. > > > > After a bit of poking around I find the > > /home/tarmac/.config/tarmac/tarmac.conf file. > > > > [lp:juju-core] > > debug_log_location = /home/tarmac/logs/ > > tree_dir = /home/tarmac/trees/src/launchpad.net/juju-core/ > > verify_command = export GOPATH=/home/tarmac/trees; go fmt ./... && go > > build ./... && go test ./... > > > > > > The verify_command here doesn't do either "go get -u ." nor use "godeps" > > to make the tree the right revisions. Did we lose this step somewhere > > in the migration to the new bot? > > > > Can we make sure we don't lose it again? > > > > We shouldn't have to do any more than update the dependencies file and > > land the branch for the new dependencies to be added. > > > > I haven't modified the bot myself because I'm a little vague on > > ownership and who maintains the "canonical" juju-core bot deployment > > details. I felt that if I just modified the bot as is, we'd lose all the > > changes when we had to redeploy again, and I don't want that. > > > > Cheers, > > Tim > > > >
-- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
