-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10.09.2013 13:01, John Arbash Meinel wrote: > On 2013-09-10 12:39, Frank Mueller wrote: >> Hi all, > >> as on-call reviewer today I've again seen the difference between > >> https://code.launchpad.net/juju-core/+activereviews > >> and > >> https://codereview.appspot.com/mine > >> There are many unclosed reviews on Rietveld. This may not be our >> main list, but it would help if those CL which are merged or >> discarded would be closed there too.
+100 > >> thx mue > > > Is that actually intended to be part of the workflow? It ends up > with several more clicks and delays for round trips (you have to > wait for your patch to land, then click back through and close the > Rietveld ticket, etc.) I just takes a second to close the CL after you submitted it for landing. Actually I always do that after I run "bzr rv-submit" on the approved branch. > > My understanding was that the "queue of things to review" was > strictly +activereviews (which has the really nice property that > Launchpad notices when it is merged and sets the MP to the right > status for us). > > John =:-> > > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJSLv0VAAoJENzxV2TbLzHwDSYIAIsGB8+4Pw/6eAMNYGHAmVQx pM7vJK9x2R40rMBUnV23OFtWFFNbSmf4hPDhkywFi8lPMTYs/at+awDpU/XYHiM5 TWn3Vh3dyiRKWvv6aNmCX2K1GzDetn7WuwWKes/zLoxnsqxaKwTYO1sIyBQnXwhy 9PpnIZutUv8R/lKhD51ISOV/1aHvITAtlyO7ZU/KKMpATeGEdC7ilPj0zRFd7VQv m/n8tv4JTwyX4C5uXG9aJmRWjcH3nDHSdFSa8s/15K+aLdzNo9cCgadATMLi6pKK ML1agXlZNmdz+4kHoApxmNgo0TvQ66dsclciiSKbFqbwAJjCevHTUnKzuKq/oWE= =rTLg -----END PGP SIGNATURE----- -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
