Also, dpSetPosition() has the wrong first sentence too.

There's a bug or documentation error with dpSetSelected() [revision #1993] :
it's documented as taking a string, but the code for it requires a Date (due
to using .getMonth(), .getFullYear() and .getTime()).

To fix this problem I added the line  d = new Date(d);  to the start of
dpSetSelected().

--rob


On 6/1/07, Rob Desbois <[EMAIL PROTECTED]> wrote:

Well, I've finally taken the plunge and started playing with datePicker.
Can I join everyone in thanking you for this excellent plugin.

Suggestions for a few changes, mainly ones which increased the time it
took for me to integrate it into a page without hacking the source:

== Change the clickInput option to be clickElement instead ==
I wanted to use <span> as my datePicker element to prevent manual editing:
forcing the use of a text input means making it disabled and re-enabling it
on form submission, or using javascript to prevent modification.

== Change the <a> created with createButton:true ==
I like the automatic creation of the <a> but dislike the default content
being text and the image being background: it means either CSS is required
to hide the content or JS to remove the content and CSS to display properly.
I've had to resort to adding my own <a> in the HTML and setting its
behaviour myself:

<a href="javascript:choose_date('dateFrom')">
>    <img src="/images/calendar.gif" alt="[choose date]" />
> </a>
>

My suggestion would be to allow the content of the <a> to be set in the
options if desired.

Also, is there a particular reason why $.dpDisplay() returns a value? It
means that to use it from the href of an <a> it has to be wrapped in another
function call returning nothing to prevent the browser from navigating away
when it's called from the href.

Just as an aside: the first sentence of documentation of dpSetOffset() on 
http://kelvinluck.com/assets/jquery/datePicker/v2/demo/documentation.html
is from the dpDisplay() function instead.

Is datePicker v2 still considered to be in beta?

Apologies for length, and many thanks for this damn good piece of kit :-)
--rob


On 5/21/07, tlphipps <[EMAIL PROTECTED]> wrote:
>
>
> Awesome!  The packing and the hovering work great!  Thanks for the
> amazing support.
>
> On May 20, 2:17 pm, Kelvin Luck <[EMAIL PROTECTED]> wrote:
> > Hi,
> >
> > I've added support for this into the date picker:
> http://dev.jquery.com/changeset/1933#file2
> >
> > As you can see, you can now pass a hoverClass to $().datePicker or
> > $().renderCalendar which is added to each TD of the calendar as you
> > hover over it. This defaults to dp-hover. You can also pass false if
> you
> > don't want any class added to the TDs.
> >
> > Hope that helps,
> >
> > Kelvin :)
> >
> > tlphipps wrote:
> > > Another issue I've uncovered is related to the :hover effects.  In
> > > your original date picker you were obviously using <a>s because the
> > > hover effect worked correctly in IE.  However, hovering doesn't work
> > > in v2 because of IE's quirkiness.
> >
> > > Anybody have any input on how to get the :hover effect back in IE
> with
> > > v2?
>
>


--
Rob Desbois
Eml: [EMAIL PROTECTED]
Tel: 01452 760631
Mob: 07946 705987
"There's a whale there's a whale there's a whale fish" he cried, and the
whale was in full view.
...Then ooh welcome. Ahhh. Ooh mug welcome.




--
Rob Desbois
Eml: [EMAIL PROTECTED]
Tel: 01452 760631
Mob: 07946 705987
"There's a whale there's a whale there's a whale fish" he cried, and the
whale was in full view.
...Then ooh welcome. Ahhh. Ooh mug welcome.

Reply via email to