alok123t commented on code in PR #12136:
URL: https://github.com/apache/kafka/pull/12136#discussion_r884129390
##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -830,7 +830,13 @@ class KafkaServer(
private def checkpointBrokerMetadata(brokerMetadata: ZkMetaProperties) = {
for (logDir <- config.logDirs if logManager.isLogDirOnline(new
File(logDir).getAbsolutePath)) {
val checkpoint = brokerMetadataCheckpoints(logDir)
- checkpoint.write(brokerMetadata.toProperties)
+ try {
+ checkpoint.write(brokerMetadata.toProperties)
+ } catch {
+ case e: IOException =>
Review Comment:
nit: fix indentation
missing tab before case statement
##########
core/src/main/scala/kafka/log/LogManager.scala:
##########
@@ -318,6 +318,11 @@ class LogManager(logDirs: Seq[File],
val jobs = ArrayBuffer.empty[Seq[Future[_]]]
var numTotalLogs = 0
+ def handleIOException(logDirAbsolutePath: String, e: IOException) = {
Review Comment:
nit: return type unit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
