cmccabe commented on code in PR #12205:
URL: https://github.com/apache/kafka/pull/12205#discussion_r883064741
##########
core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala:
##########
@@ -725,4 +726,56 @@ class KRaftClusterTest {
cluster.close()
}
}
+
+ private def clusterImage(
+ cluster: KafkaClusterTestKit,
+ brokerId: Int
+ ): ClusterImage = {
+ cluster.brokers().get(brokerId).metadataCache.currentImage().cluster()
+ }
+
+ private def brokerIsUnfenced(
+ image: ClusterImage,
+ brokerId: Int
+ ): Boolean = {
+ Option(image.brokers().get(brokerId)) match {
+ case None => false
+ case Some(registration) => !registration.fenced()
+ }
+ }
+
+ private def brokerIsAbsent(
+ image: ClusterImage,
+ brokerId: Int
+ ): Boolean = {
+ Option(image.brokers().get(brokerId)).isEmpty
+ }
+
+ @Test
+ def testUnregisterBroker(): Unit = {
+ val cluster = new KafkaClusterTestKit.Builder(
+ new TestKitNodes.Builder().
+ setNumBrokerNodes(4).
+ setNumControllerNodes(3).build()).build()
+ try {
+ cluster.format()
+ cluster.startup()
+ cluster.waitForReadyBrokers()
+ TestUtils.waitUntilTrue(() => brokerIsUnfenced(clusterImage(cluster, 1),
0),
+ "Timed out waiting for broker 0 to be unfenced.")
+ cluster.brokers().get(0).shutdown()
+ TestUtils.waitUntilTrue(() => !brokerIsUnfenced(clusterImage(cluster,
1), 0),
+ "Timed out waiting for broker 0 to be fenced.")
+ val admin = Admin.create(cluster.clientProperties())
+ try {
Review Comment:
Hmm, the try..catch block seems more like normal Scala style to me. So I'll
leave it as-is for now...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
