hachikuji commented on code in PR #12189:
URL: https://github.com/apache/kafka/pull/12189#discussion_r878330637
##########
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##########
@@ -697,6 +697,19 @@ class TopicCommandIntegrationTest extends
KafkaServerTestHarness with Logging wi
try {
killBroker(0)
killBroker(1)
+
+ val aliveServers = brokers.filterNot(brokers => brokers.config.brokerId
== 0 || brokers.config.brokerId == 1)
+
+ if (isKRaftTest()) {
+ TestUtils.ensureConsistentKRaftMetadata(aliveServers, controllerServer,
Review Comment:
We have a helper `KafkaServerTestHarness.ensureConsistentKRaftMetadata`. I
think it would make sense to modify it to use only the alive brokers. Then we
could use it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
