dengziming commented on code in PR #12109:
URL: https://github.com/apache/kafka/pull/12109#discussion_r875363131
##########
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##########
@@ -158,7 +158,7 @@ class ZkAdminManager(val config: KafkaConfig,
val nullConfigs = topic.configs.asScala.filter(_.value ==
null).map(_.name)
if (nullConfigs.nonEmpty)
- throw new InvalidRequestException(s"Null value not supported for
topic configs : ${nullConfigs.mkString(",")}")
+ throw new ConfigException(s"Null value not supported for topic
configs: ${nullConfigs.mkString(",")}")
Review Comment:
Yeah, `ConfigException ` is not used in `CreateTopics` currently, I changed
it to `InvalidConfigurationException`, and in `LogConfig.validate(config)` we
will also use `InvalidConfigurationException` so it's already an expected error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
