mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r875105840
##########
metadata/src/main/java/org/apache/kafka/image/MetadataDelta.java:
##########
@@ -253,6 +263,14 @@ public void replay(RemoveTopicRecord record) {
public void replay(FeatureLevelRecord record) {
getOrCreateFeaturesDelta().replay(record);
+ featuresDelta.metadataVersionChange().ifPresent(__ -> {
+ // If any feature flags change, need to trigger components to
possibly handle the new flags
Review Comment:
AclsDelta ✅
Yea I realize there is some missing code here, but since we don't have any
use downgrade cases yet I didn't want to spend too much time on this. For now,
I added a no-op method on each of the Delta classes that will let them handle a
metadata.version downgrade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
