dajac commented on code in PR #12138:
URL: https://github.com/apache/kafka/pull/12138#discussion_r874516358
##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -578,7 +579,8 @@ class Partition(val topicPartition: TopicPartition,
// Updating the assignment and ISR state is safe if the partition epoch
is
// larger or equal to the current partition epoch.
updateAssignmentAndIsr(
- assignment = partitionState.replicas.asScala.map(_.toInt),
+ assignment = replicas,
+ followers = replicas.filter(_ != localBrokerId),
Review Comment:
On second thought, it seems that the `isLeader` flag option is more
efficient because it allows to clear the remote replicas map for followers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
