aiquestion commented on PR #11451: URL: https://github.com/apache/kafka/pull/11451#issuecomment-1120979810
@showuon we are facing the same issue, and i want to ask is the issue https://issues.apache.org/jira/browse/KAFKA-13419 get fixed in this PR? Or we still need [KIP-792](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=191336614) to fix this. for the original 2 places to fix: 1. Inside the ConsumerCoordinator#subscriptions, where we save the currently assigned partitions. 2. Inside the Assignor#userData, where for (cooperative) sticky assignor where we also encode the generation and the prev-assigned partitions as memberAssignment (note that in join-group request we do not encode the generation id). In this change you want to fix the 1) one, but found that it will cause rebalance wait for session timeout, because memberId reset. Seems only reset geneartionId when SyncGroupReqeust got RebalanceInProcess error can be a workaround for this.( i did some test and it works) But you didn't do the reset it in your final code. Thanks a lot~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
