rittikaadhikari commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r866395929
##########
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##########
@@ -51,6 +51,7 @@ import scala.math._
*/
abstract class AbstractFetcherThread(name: String,
clientId: String,
+ val leader: LeaderEndPoint,
Review Comment:
We could end up having something like the following:
```
trait LeaderEndPoint {
def brokerEndPoint(): BrokerEndPoint
....
}
class LocalLeaderEndPoint(sourceBroker: brokerEndPoint, ....) extends
LeaderEndPoint {
def brokerEndPoint(): return sourceBroker
class RemoteLeaderEndPoint(endpoint: BlockingSend, ...) extends
LeaderEndPoint {
def brokerEndPoint(): return endpoint.sourceBroker
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
