showuon commented on code in PR #11211:
URL: https://github.com/apache/kafka/pull/11211#discussion_r857222660
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java:
##########
@@ -234,7 +275,11 @@ public void put(final Bytes key,
@Override
public byte[] get(final Bytes key) {
- final S segment =
segments.getSegmentForTimestamp(keySchema.segmentTimestamp(key));
+ final long timestampFromKey = keySchema.segmentTimestamp(key);
+ // check if timestamp is expired
+ if (timestampFromKey < observedStreamTime - retentionPeriod + 1)
+ return null;
Review Comment:
Any thoughts for the comment?
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractDualSchemaRocksDBSegmentedBytesStoreTest.java:
##########
@@ -157,43 +157,34 @@ public void shouldPutAndFetch() {
try (final KeyValueIterator<Bytes, byte[]> values = bytesStore.fetch(
Bytes.wrap(keyA.getBytes()), 0, windows[2].start())) {
- final List<KeyValue<Windowed<String>, Long>> expected = asList(
- KeyValue.pair(new Windowed<>(keyA, windows[0]), 10L),
- KeyValue.pair(new Windowed<>(keyA, windows[1]), 50L)
- );
+ // all records expired as actual from is 59001 and to is 1000
Review Comment:
Any thoughts for the comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
