dajac commented on code in PR #12081:
URL: https://github.com/apache/kafka/pull/12081#discussion_r856890114
##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -885,15 +885,18 @@ class Partition(val topicPartition: TopicPartition,
*
* @return true if the HW was incremented, and false otherwise.
*/
- private def maybeIncrementLeaderHW(leaderLog: UnifiedLog, curTime: Long =
time.milliseconds): Boolean = {
+ private def maybeIncrementLeaderHW(leaderLog: UnifiedLog, currentTimeMs:
Long = time.milliseconds): Boolean = {
Review Comment:
We have a few other calls where `currentTimeMs` is not computed beforehand.
I will update `makeLeader` to pass it directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
