hachikuji commented on code in PR #12071:
URL: https://github.com/apache/kafka/pull/12071#discussion_r855689378
##########
core/src/test/scala/unit/kafka/zk/KafkaZkClientTest.scala:
##########
@@ -922,10 +922,10 @@ class KafkaZkClientTest extends QuorumTestHarness {
private def leaderIsrAndControllerEpochs(state: Int, zkVersion: Int):
Map[TopicPartition, LeaderIsrAndControllerEpoch] =
Review Comment:
nit: `zkVersion` -> `partitionEpoch`?
##########
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##########
@@ -1277,7 +1277,7 @@ object TestUtils extends Logging {
def completeIsrUpdate(newZkVersion: Int): Unit = {
Review Comment:
Should we change `newZkVersion` to `newPartitionEpoch`?
##########
core/src/test/scala/unit/kafka/controller/ReplicaStateMachineTest.scala:
##########
@@ -213,7 +213,7 @@ class ReplicaStateMachineTest {
val stat = new Stat(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0)
val adjustedLeaderAndIsr =
leaderAndIsr.newLeaderAndIsr(LeaderAndIsr.NoLeader, List(otherBrokerId))
- val updatedLeaderAndIsr =
adjustedLeaderAndIsr.withZkVersion(adjustedLeaderAndIsr .zkVersion + 1)
+ val updatedLeaderAndIsr =
adjustedLeaderAndIsr.withPartitionEpoch(adjustedLeaderAndIsr .partitionEpoch +
1)
Review Comment:
nit: looks like an extra space before the `.partitionEpoch`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
