[GitHub] [kafka] dajac commented on a diff in pull request #12071: KAFKA-13790; ReplicaManager should be robust to all partition updates from kraft metadata log (1)

[GitBox]

dajac commented on code in PR #12071:
URL: https://github.com/apache/kafka/pull/12071#discussion_r854191977


##########
clients/src/main/resources/common/message/LeaderAndIsrRequest.json:
##########
@@ -78,8 +78,8 @@
         "about": "The leader epoch." },
       { "name": "Isr", "type": "[]int32", "versions": "0+", "entityType": 
"brokerId",
         "about": "The in-sync replica IDs." },
-      { "name": "ZkVersion", "type": "int32", "versions": "0+",
-        "about": "The ZooKeeper version." },
+      { "name": "PartitionEpoch", "type": "int32", "versions": "0+",
+        "about": "The current epoch for the partition for KRaft controllers. 
The current ZK version for the legacy controllers." },

Review Comment:
   That's right. However, we use `LeaderAndIsrPartitionState` in many places 
internally in the ReplicaManager and in the Partition so it makes sense to 
unify the naming at this level, I think.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org