ijuma commented on code in PR #10826:
URL: https://github.com/apache/kafka/pull/10826#discussion_r850509560
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -523,6 +532,45 @@ boolean idempotenceEnabled() {
return userConfiguredTransactions || idempotenceEnabled;
}
+ public CompressionConfig getCompressionConfig(CompressionType
compressionType) {
+ if (getString(ProducerConfig.COMPRESSION_LEVEL_CONFIG).isEmpty()) {
Review Comment:
Why don't we push some of these things to the enum itself?
`CompressionType.config(String level)` or something like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
