dengziming commented on code in PR #12024:
URL: https://github.com/apache/kafka/pull/12024#discussion_r850102307
##########
core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala:
##########
@@ -391,7 +298,7 @@ class ConfigCommandTest extends QuorumTestHarness with
Logging {
def shouldFailIfUnrecognisedEntityTypeUsingZookeeper(): Unit = {
val createOpts = new ConfigCommandOptions(Array("--zookeeper", zkConnect,
"--entity-name", "client", "--entity-type", "not-recognised", "--alter",
"--add-config", "a=b,c=d"))
- assertThrows(classOf[IllegalArgumentException], () =>
ConfigCommand.alterConfigWithZk(null, createOpts, new
DummyAdminZkClient(zkClient)))
+ assertThrows(classOf[IllegalArgumentException], () =>
ConfigCommand.alterConfigWithZk(null, createOpts, new DummyAdminZkClient(null)))
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
