[GitHub] [kafka] ddrid commented on a diff in pull request #12006: KAFKA-13794: Follow up to fix comparator

[GitBox]

ddrid commented on code in PR #12006:
URL: https://github.com/apache/kafka/pull/12006#discussion_r844881404


##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -187,7 +187,7 @@ private void startSequencesAtBeginning(TopicPartition 
topicPartition, ProducerId
         private static final Comparator<ProducerBatch> 
PRODUCER_BATCH_COMPARATOR = (b1, b2) -> {
             if (b1.baseSequence() < b2.baseSequence()) return -1;
             else if (b1.baseSequence() > b2.baseSequence()) return 1;
-            else return b1.equals(b2) ? 0 : 1;
+            else return b1.equals(b2) ? 0 : Integer.compare(b1.hashCode(), 
b2.hashCode());

Review Comment:
   Hi @showuon, thanks for you comment. I found some trouble when adding 
`equals` method in `ProducerBatch`. The only two final fields I can use is 
`createdMs` and `topicPartition`, I don't think it make sense if I use these 
two fields since they usually have duplicates. Do you have some suggestions? 
Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org