ableegoldman commented on a change in pull request #11705:
URL: https://github.com/apache/kafka/pull/11705#discussion_r827565592



##########
File path: streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java
##########
@@ -53,36 +59,42 @@
     private static final ConfigDef CONFIG;

Review comment:
       Maybe make a note in the javadocs that settings values for anything in 
TopologyConfig will result in that overriding the value set in the 
StreamsConfig passed in to the KafkaStreams. The current javadocs kind of hint 
at it but they're more focused on named topologies so I don't think it's really 
that clear




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to