showuon commented on pull request #11800:
URL: https://github.com/apache/kafka/pull/11800#issuecomment-1051835536
> if (!unknown().contains(key)) {
used.add(key);
}
The reason we call `ignore` is because we indeed **use** this config key. In
your logic, it'll make the **used** config keys not existed in `used` set (when
it's unknown). It will confuse other developers, even though we can make the
test pass.
I think we should remove all `used` keys in `unknown` method. That will
exclude all `used` keys when retrieving `unknown` config keys. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
