C0urante commented on a change in pull request #11572:
URL: https://github.com/apache/kafka/pull/11572#discussion_r814955840
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/entities/ConnectorPluginInfo.java
##########
@@ -79,11 +82,21 @@ public int hashCode() {
@Override
public String toString() {
- final StringBuilder sb = new StringBuilder("ConnectorPluginInfo{");
- sb.append("className='").append(className).append('\'');
- sb.append(", type=").append(type);
- sb.append(", version='").append(version).append('\'');
- sb.append('}');
- return sb.toString();
+ return "ConnectorPluginInfo{" + "className='" + className + '\'' +
+ ", type=" + type.toString() +
+ ", version='" + version + '\'' +
+ '}';
+ }
+
+ public static final class NoVersionFilter {
+ @Override
+ public boolean equals(Object obj) {
+ return DelegatingClassLoader.UNDEFINED_VERSION.equals(obj);
+ }
+
+ @Override
+ public int hashCode() {
+ return super.hashCode();
+ }
Review comment:
Ah yeah, compiler warning about overriding `equals` but not `hashCode`.
Think we should leave a comment about that just so others don't wonder the same
thing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
