showuon commented on a change in pull request #11642:
URL: https://github.com/apache/kafka/pull/11642#discussion_r811908842



##########
File path: 
connect/runtime/src/main/java/org/apache/kafka/connect/tools/PredicateDoc.java
##########
@@ -61,7 +61,7 @@ private static void printPredicateHtml(PrintStream out, 
DocInfo docInfo) {
         out.println("<div id=\"" + docInfo.predicateName + "\">");
 
         out.print("<h5>");
-        out.print(docInfo.predicateName);
+        out.print("<a href=\"#" + docInfo.predicateName + "\">" + 
docInfo.predicateName + "</a>");

Review comment:
       OK, I got it. You want to add an anchor point in each predicate and 
transformation. I see now. I've checked, there is already the HTML element `id` 
= predicate names and transformation names, so adding an anchor link with the 
name can link to the position. Looks good to me. Thanks for the explanation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to