showuon commented on a change in pull request #11493:
URL: https://github.com/apache/kafka/pull/11493#discussion_r805556147



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java
##########
@@ -997,6 +997,77 @@ public void testAssignWithStandbyReplicas() {
         assertEquals(standbyPartitionsByHost, info20.standbyPartitionByHost());
     }
 
+    @Test
+    public void testAssignWithStandbyReplicasBalance() {

Review comment:
       Could we add some tests to cover the are less than total tasks (active + 
standby), but we can still distribute them evenly (the test case should be more 
common for users), ex:
   tasks: TASK_0_0, TASK_0_1, TASK_0_2
   consumers: 2 in thread1, 3 in thread2
   We expected each thread should have 3 tasks, and distribute evenly. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to