hachikuji commented on a change in pull request #11655:
URL: https://github.com/apache/kafka/pull/11655#discussion_r802933225
##########
File path:
core/src/test/scala/unit/kafka/server/CreateTopicsRequestWithPolicyTest.scala
##########
@@ -55,11 +63,9 @@ class CreateTopicsRequestWithPolicyTest extends
AbstractCreateTopicsRequestTest
assignment = Map(0 -> List(1, 0), 1 -> List(0, 1))))))
}
- @Test
- def testErrorCreateTopicsRequests(): Unit = {
- val existingTopic = "existing-topic"
- createTopic(existingTopic, 1, 1)
Review comment:
Do we need to? Seems like the main thing we're testing here is the case
when the topic already exists. Seems like it would be just as good to create
with the admin client and then verify the `TOPIC_ALREADY_EXISTS` error code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
