mjsax commented on pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#issuecomment-1027357002


   Btw: this PR does not update the docs -- we should docs updates, too. (Also 
ok to do in a follow up PR.)
   
   To ensure backward compatibility, it might also be good to split the 
actually PR into two: first so the internal config change without rewriting any 
tests -- this should ensure that no existing test breaks. -- In a follow up PR 
we update the test to use the new config.
   
   And we should add a test that expliclity tests the old config to test 
backward compatibility explicitly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to