cmccabe commented on a change in pull request #11657:
URL: https://github.com/apache/kafka/pull/11657#discussion_r789786332
##########
File path:
core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala
##########
@@ -258,6 +270,15 @@ class BrokerMetadataPublisher(conf: KafkaConfig,
// recovery-from-unclean-shutdown if required.
logManager.startup(metadataCache.getAllTopics())
+ // Make the LogCleaner available for reconfiguration. We can't do this
prior to this
+ // point because LogManager#startup creates the LogCleaner object, if
+ // log.cleaner.enable is true.
+ //
+ // TODO: it would probably be better to make log.cleaner.enable dynamically
+ // configurable as well. It would also be cleaner to unconditionally
create the log
+ // cleaner object in the LogManager constructor even if we never start it.
Review comment:
OK. I created https://issues.apache.org/jira/browse/KAFKA-13610 for
this. I will reference that JIRA here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
