patrickstuedi commented on a change in pull request #11676:
URL: https://github.com/apache/kafka/pull/11676#discussion_r789710920
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java
##########
@@ -85,8 +85,23 @@
* @throws IllegalStateException If store gets registered after
initialized is already finished
* @throws StreamsException if the store's change log does not contain the
partition
*/
+ default void register(final StateStore store,
Review comment:
I understand the basic logic here, but that also means in the deprecated
init of the state stores (those with the ProcessorContext) the stores will not
be able to register the callback. Why don't we keep the checkpoint callback in
both ProcessorContext::register and the StateStoreContext::register and mark
the one in ProcessorContext deprecated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
