mjsax commented on a change in pull request #11592:
URL: https://github.com/apache/kafka/pull/11592#discussion_r788073751



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -228,8 +228,9 @@ public void initializeIfNeeded() {
         if (state() == State.CREATED) {
             recordCollector.initialize();
 
-            StateManagerUtil.registerStateStores(log, logPrefix, topology, 
stateMgr, stateDirectory, processorContext);
+            mainConsumer.enforceRebalance();

Review comment:
       Why do we do this call?

##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##########
@@ -465,6 +465,13 @@ boolean tryToCompleteRestoration(final long now, final 
java.util.function.Consum
             } catch (final TimeoutException timeoutException) {
                 task.maybeInitTaskTimeoutOrThrow(now, timeoutException);
                 allRunning = false;
+            } catch (final TaskCorruptedException te) {

Review comment:
       Why do we need this?
   
   The idea of the ticket was to change existing code that catches 
`TaskCorruptionException`: after we wipe out the local state store, we trigger 
a rebalance if standbys are enabled.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to