mjsax commented on a change in pull request #11535:
URL: https://github.com/apache/kafka/pull/11535#discussion_r772838710
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -1097,15 +1097,20 @@ long decodeTimestamp(final String encryptedString) {
if (encryptedString.isEmpty()) {
return RecordQueue.UNKNOWN;
}
- final ByteBuffer buffer =
ByteBuffer.wrap(Base64.getDecoder().decode(encryptedString));
- final byte version = buffer.get();
- switch (version) {
- case LATEST_MAGIC_BYTE:
- return buffer.getLong();
- default:
- log.warn("Unsupported offset metadata version found. Supported
version {}. Found version {}.",
- LATEST_MAGIC_BYTE, version);
- return RecordQueue.UNKNOWN;
+ try {
+ final ByteBuffer buffer =
ByteBuffer.wrap(Base64.getDecoder().decode(encryptedString));
+ final byte version = buffer.get();
+ switch (version) {
+ case LATEST_MAGIC_BYTE:
+ return buffer.getLong();
+ default:
+ log.warn("Unsupported offset metadata version found.
Supported version {}. Found version {}.",
+ LATEST_MAGIC_BYTE, version);
+ return RecordQueue.UNKNOWN;
+ }
+ } catch (final IllegalArgumentException argumentException) {
Review comment:
Sorry for the follow up comment (should have added this right away): why
are we catching `IllegalArgumentException`? Would it be better to just catch
`Exception` to cover all potential error cases? `buffer.get()` could throw a
`BufferUnderflowException` for example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
