dajac commented on a change in pull request #11571:
URL: https://github.com/apache/kafka/pull/11571#discussion_r771376907
##########
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##########
@@ -617,9 +617,10 @@ class GroupCoordinator(val brokerId: Int,
leavingMembers: List[MemberIdentity],
responseCallback: LeaveGroupResult => Unit): Unit = {
- def removeCurrentMemberFromGroup(group: GroupMetadata, memberId: String):
Unit = {
+ def removeCurrentMemberFromGroup(group: GroupMetadata, memberId: String,
reason: Option[String]): Unit = {
val member = group.get(memberId)
- removeMemberAndUpdateGroup(group, member, s"Removing member $memberId on
LeaveGroup")
+ val leaveReason = reason.getOrElse("unknown reason")
+ removeMemberAndUpdateGroup(group, member, s"Removing member $memberId on
LeaveGroup due to: $leaveReason")
Review comment:
I think that we should use the same pattern for both join reasons and
leave reason. See
https://github.com/apache/kafka/pull/11566#discussion_r771371068.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
