vvcephei commented on a change in pull request #10528:
URL: https://github.com/apache/kafka/pull/10528#discussion_r751376161
##########
File path: build.gradle
##########
@@ -2400,6 +2401,7 @@ project(':connect:runtime') {
testImplementation project(':core')
testImplementation project(':metadata')
testImplementation project(':core').sourceSets.test.output
+ testImplementation project(':streams').sourceSets.test.output
Review comment:
Since you've moved the util, do you still need this dependency?
##########
File path: build.gradle
##########
@@ -1205,6 +1205,7 @@ project(':clients') {
testImplementation libs.bcpkix
testImplementation libs.junitJupiter
+ testImplementation libs.log4j
Review comment:
I wonder if we can drop this dependency from Streams now. Do you mind
checking?
##########
File path: checkstyle/import-control.xml
##########
@@ -531,6 +529,7 @@
<allow pkg="org.reflections.util"/>
<allow pkg="javax.crypto"/>
<allow pkg="org.eclipse.jetty.util" />
+ <allow pkg="org.apache.kafka.streams.processor.internals.testutil" />
Review comment:
Interesting. We had an import restriction on pulling in a Streams
dependency?
Actually, it looks like the util isn't in this package anymore at all, so
this is probably not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
