C0urante commented on a change in pull request #11046:
URL: https://github.com/apache/kafka/pull/11046#discussion_r753386502
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##########
@@ -638,15 +636,15 @@ public void onFailure(RuntimeException e) {
/**
* Return the fetched records, empty the record buffer and update the
consumed position.
*
- * NOTE: returning empty records guarantees the consumed position are NOT
updated.
+ * NOTE: returning an {@link Fetch#isEmpty empty} fetch guarantees the
consumed position is not updated.
Review comment:
Thanks, this is much simpler. I've taken a stab at an approach that's
agnostic with regard to the cause of the position advancing and only tracks
whether any advancement has taken place; hope this looks something like what
you had in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
